Conversation
Contributor
Author
|
@jaraco By all means this shouldn't affect users in any way, but should help me with a WIP PR in setuptools and in typeshed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought this wouldn't do anything shipped as a setuptools submodule, but it turns out pyright does understand it as part of its support for submodules for namespace packages. So it's actually useful.
The spec isn't completely clear here. But for type-checkers that understand it: it's a benefit. And for those that don't, nothing changes.
I think
distutils/compilersis considered a namespace package, hence the need for the secondpy.typedWithout:

With:

Relates to:
distutils-stubson install setuptools#4861